Skip to content

fix(reconciler): prevent crash when removing elements#3261

Merged
diegomura merged 2 commits intodiegomura:masterfrom
Nukem154:reconciler-detach-deleted-elements
Dec 28, 2025
Merged

fix(reconciler): prevent crash when removing elements#3261
diegomura merged 2 commits intodiegomura:masterfrom
Nukem154:reconciler-detach-deleted-elements

Conversation

@Nukem154
Copy link
Contributor

@Nukem154 Nukem154 commented Dec 27, 2025

Removing elements can trigger an "eo is not a function" runtime error.
This occurs because detachDeletedInstance is not passed to the React Reconciler, causing cleanup logic to fail during element removal.

This PR fixes the issue by passing detachDeletedInstance into the Reconciler config

Fixes #3153
Fixes #3187
Fixes #3164
Fixes #2978

@changeset-bot
Copy link

changeset-bot bot commented Dec 27, 2025

🦋 Changeset detected

Latest commit: 7d68567

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@react-pdf/reconciler Patch
@react-pdf/renderer Patch
next-14 Patch
next-15 Patch
@react-pdf/vite-example Patch
@react-pdf/e2e-node-cjs Patch
@react-pdf/e2e-node-esm Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@diegomura diegomura merged commit 2eba70b into diegomura:master Dec 28, 2025
@Nukem154 Nukem154 deleted the reconciler-detach-deleted-elements branch December 28, 2025 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants